Kiril Vladimiroff
7abd114aa4
Override named result parameters in last returns
...
Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>
2020-02-06 11:27:28 +02:00
Kiril Vladimiroff
59465746bc
Always defer *sql.Rows.Close and consult with Err
...
database/sql.Rows.Next() makes sure to call Close only after exhausting
result rows which would NOT happen when returning early from a bad Scan.
Close being idempotent makes it a great candidate to get always deferred
regardless of what happens later on the result set.
This change also makes sure call Err() after exhausting Next() and
propagate non-nil results from it as the documentation advises.
Closes #764
Signed-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>
2020-02-06 11:27:24 +02:00
Neil Alexander
68ee11d96c
Add empty push rules into account data on account creation ( #862 )
2020-01-30 11:20:44 +00:00
Alex Chen
e959927d0a
selectAccountDataByType shouldn't error when no rows ( #804 )
...
Signed-off-by: Alex Chen <minecnly@gmail.com>
2019-10-07 13:15:58 +01:00
Behouba Manassé
49fd47c863
selectAccountDataByType return ClientEvent pointer instead of slice of ClientEvent ( #798 )
...
This pull request is an attempt to fix #773 .
Signed-off-by: Kouame Behouba Manassé behouba@gmail.com
2019-09-30 17:25:04 +01:00
Alex Chen
43308d2f3f
Associate transactions with session IDs instead of device IDs ( #789 )
2019-08-24 00:55:40 +08:00
Alex Chen
f8d2860765
Replace membership and visibility values with constants ( #774 )
...
Signed-off-by: Alex Chen <minecnly@gmail.com>
2019-08-06 15:07:36 +01:00
Thibaut CHARLES
b729a10366
Store & retrieve filters as structs rather than []byte ( #436 )
...
Manipulate filters as gomatrix.Filter structures, instead of their []byte JSON representation.
This lays ground work for using filters in dendrite for /sync requests.
2019-07-25 00:08:51 +08:00
Andrew Morgan
78032b3f4c
Correctly create new device when device_id is passed to /login ( #753 )
...
Fixes https://github.com/matrix-org/dendrite/issues/401
Currently when passing a `device_id` parameter to `/login`, which is [supposed](https://matrix.org/docs/spec/client_server/unstable#post-matrix-client-r0-login ) to return a device with that ID set, it instead just generates a random `device_id` and hands that back to you.
The code was already there to do this correctly, it looks like it had just been broken during some change. Hopefully sytest will prevent this from becoming broken again.
2019-07-22 15:05:38 +01:00
Andrew Morgan
bc382bba46
Fix pipeline, emoji and syntax ( #713 )
...
Fixes #697
Switched to golangci-lint, fixes issues with buildkite and does some linting fixes to appease the new linters.
2019-06-19 14:05:03 +01:00
ruben
74827428bd
use go module for dependencies ( #594 )
2019-05-21 21:56:55 +01:00
