dendrite/syncapi/storage/cosmosdb/account_data_table.go
alexfca 3088238419
Add UniqueId to PartitionKey for some Dendrite tables (where possible) (#19)
* - Make all PartitionKeys include the tablename
- Update specific PKs to be item specific
- Add validation to the PerformQueryXX methods
- Fix queries that fail validation

* - Revert the PK back to CollectionName as it already includes the TableName

Co-authored-by: alexf@example.com <alexf@example.com>
2021-09-23 14:48:32 +10:00

269 lines
7.7 KiB
Go

// Copyright 2017-2018 New Vector Ltd
// Copyright 2019-2020 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package cosmosdb
import (
"context"
"database/sql"
"fmt"
"github.com/matrix-org/dendrite/internal/cosmosdbutil"
"github.com/matrix-org/dendrite/internal/cosmosdbapi"
"github.com/matrix-org/dendrite/syncapi/storage/tables"
"github.com/matrix-org/dendrite/syncapi/types"
"github.com/matrix-org/gomatrixserverlib"
)
// const accountDataSchema = `
// CREATE TABLE IF NOT EXISTS syncapi_account_data_type (
// id INTEGER PRIMARY KEY,
// user_id TEXT NOT NULL,
// room_id TEXT NOT NULL,
// type TEXT NOT NULL,
// UNIQUE (user_id, room_id, type)
// );
// `
type accountDataTypeCosmos struct {
ID int64 `json:"id"`
UserID string `json:"user_id"`
RoomID string `json:"room_id"`
DataType string `json:"type"`
}
type AccountDataTypeNumberCosmosData struct {
Number int64 `json:"number"`
}
type accountDataTypeCosmosData struct {
cosmosdbapi.CosmosDocument
AccountDataType accountDataTypeCosmos `json:"mx_syncapi_account_data_type"`
}
// const insertAccountDataSQL = "" +
// "INSERT INTO syncapi_account_data_type (id, user_id, room_id, type) VALUES ($1, $2, $3, $4)" +
// " ON CONFLICT (user_id, room_id, type) DO UPDATE" +
// " SET id = $5"
// "SELECT room_id, type FROM syncapi_account_data_type" +
// " WHERE user_id = $1 AND id > $2 AND id <= $3" +
// " ORDER BY id ASC"
const selectAccountDataInRangeSQL = "" +
"select * from c where c._cn = @x1 " +
"and c.mx_syncapi_account_data_type.user_id = @x2 " +
"and c.mx_syncapi_account_data_type.id > @x3 " +
"and c.mx_syncapi_account_data_type.id < @x4 " +
"order by c.mx_syncapi_account_data_type.id "
// "SELECT MAX(id) FROM syncapi_account_data_type"
const selectMaxAccountDataIDSQL = "" +
"select max(c.mx_syncapi_account_data_type.id) as number from c where c._cn = @x1 " +
"and c._sid = @x2 "
type accountDataStatements struct {
db *SyncServerDatasource
streamIDStatements *streamIDStatements
insertAccountDataStmt *sql.Stmt
selectMaxAccountDataIDStmt string
selectAccountDataInRangeStmt string
tableName string
}
func (s *accountDataStatements) getCollectionName() string {
return cosmosdbapi.GetCollectionName(s.db.databaseName, s.tableName)
}
func (s *accountDataStatements) getPartitionKey() string {
//No easy PK, so just use the collection
return cosmosdbapi.GetPartitionKeyByCollection(s.db.cosmosConfig.TenantName, s.getCollectionName())
}
func getAccountDataType(s *accountDataStatements, ctx context.Context, pk string, docId string) (*accountDataTypeCosmosData, error) {
response := accountDataTypeCosmosData{}
err := cosmosdbapi.GetDocumentOrNil(
s.db.connection,
s.db.cosmosConfig,
ctx,
pk,
docId,
&response)
if response.Id == "" {
return nil, nil
}
return &response, err
}
func NewCosmosDBAccountDataTable(db *SyncServerDatasource, streamID *streamIDStatements) (tables.AccountData, error) {
s := &accountDataStatements{
db: db,
streamIDStatements: streamID,
}
s.selectMaxAccountDataIDStmt = selectMaxAccountDataIDSQL
s.selectAccountDataInRangeStmt = selectAccountDataInRangeSQL
s.tableName = "account_data_types"
return s, nil
}
func (s *accountDataStatements) InsertAccountData(
ctx context.Context, txn *sql.Tx,
userID, roomID, dataType string,
) (pos types.StreamPosition, err error) {
// "INSERT INTO syncapi_account_data_type (id, user_id, room_id, type) VALUES ($1, $2, $3, $4)" +
// " ON CONFLICT (user_id, room_id, type) DO UPDATE" +
// " SET id = $5"
pos, err = s.streamIDStatements.nextAccountDataID(ctx, txn)
if err != nil {
return
}
// UNIQUE (user_id, room_id, type)
docId := fmt.Sprintf("%s_%s_%s", userID, roomID, dataType)
cosmosDocId := cosmosdbapi.GetDocumentId(s.db.cosmosConfig.TenantName, s.getCollectionName(), docId)
dbData, _ := getAccountDataType(s, ctx, s.getPartitionKey(), cosmosDocId)
if dbData != nil {
dbData.SetUpdateTime()
dbData.AccountDataType.ID = int64(pos)
} else {
data := accountDataTypeCosmos{
ID: int64(pos),
UserID: userID,
RoomID: roomID,
DataType: dataType,
}
dbData = &accountDataTypeCosmosData{
CosmosDocument: cosmosdbapi.GenerateDocument(s.getCollectionName(), s.db.cosmosConfig.TenantName, s.getPartitionKey(), cosmosDocId),
AccountDataType: data,
}
}
// _, err = sqlutil.TxStmt(txn, s.insertAccountDataStmt).ExecContext(ctx, pos, userID, roomID, dataType, pos)
err = cosmosdbapi.UpsertDocument(ctx,
s.db.connection,
s.db.cosmosConfig.DatabaseName,
s.db.cosmosConfig.ContainerName,
dbData.Pk,
dbData)
return
}
func (s *accountDataStatements) SelectAccountDataInRange(
ctx context.Context,
userID string,
r types.Range,
accountDataFilterPart *gomatrixserverlib.EventFilter,
) (data map[string][]string, err error) {
data = make(map[string][]string)
// "SELECT room_id, type FROM syncapi_account_data_type" +
// " WHERE user_id = $1 AND id > $2 AND id <= $3" +
// " ORDER BY id ASC"
// rows, err := s.selectAccountDataInRangeStmt.QueryContext(ctx, userID, r.Low(), r.High())
params := map[string]interface{}{
"@x1": s.getCollectionName(),
"@x2": userID,
"@x3": r.Low(),
"@x4": r.High(),
}
var rows []accountDataTypeCosmosData
err = cosmosdbapi.PerformQuery(ctx,
s.db.connection,
s.db.cosmosConfig.DatabaseName,
s.db.cosmosConfig.ContainerName,
s.getPartitionKey(), s.selectAccountDataInRangeStmt, params, &rows)
if err != nil {
return
}
var entries int
for _, item := range rows {
var dataType string
var roomID string
roomID = item.AccountDataType.RoomID
dataType = item.AccountDataType.DataType
// check if we should add this by looking at the filter.
// It would be nice if we could do this in SQL-land, but the mix of variadic
// and positional parameters makes the query annoyingly hard to do, it's easier
// and clearer to do it in Go-land. If there are no filters for [not]types then
// this gets skipped.
for _, includeType := range accountDataFilterPart.Types {
if includeType != dataType { // TODO: wildcard support
continue
}
}
for _, excludeType := range accountDataFilterPart.NotTypes {
if excludeType == dataType { // TODO: wildcard support
continue
}
}
if len(data[roomID]) > 0 {
data[roomID] = append(data[roomID], dataType)
} else {
data[roomID] = []string{dataType}
}
entries++
if entries >= accountDataFilterPart.Limit {
break
}
}
return data, nil
}
func (s *accountDataStatements) SelectMaxAccountDataID(
ctx context.Context, txn *sql.Tx,
) (id int64, err error) {
// "SELECT MAX(id) FROM syncapi_account_data_type"
var nullableID sql.NullInt64
// err = sqlutil.TxStmt(txn, s.selectMaxAccountDataIDStmt).QueryRowContext(ctx).Scan(&nullableID)
params := map[string]interface{}{
"@x1": s.getCollectionName(),
"@x2": s.db.cosmosConfig.TenantName,
}
var rows []AccountDataTypeNumberCosmosData
err = cosmosdbapi.PerformQueryAllPartitions(ctx,
s.db.connection,
s.db.cosmosConfig.DatabaseName,
s.db.cosmosConfig.ContainerName,
s.selectMaxAccountDataIDStmt, params, &rows)
if err != cosmosdbutil.ErrNoRows && len(rows) == 1 {
nullableID.Int64 = rows[0].Number
}
if nullableID.Valid {
id = nullableID.Int64
}
return
}