mirror of
https://github.com/matrix-org/dendrite.git
synced 2024-11-30 02:01:56 -06:00
ad6b902b84
This PR refactors the app services component. It makes the following changes:
* Each appservice now gets its own NATS JetStream consumer
* The appservice database is now removed entirely, since we just use JetStream as a data source instead
* The entire component is now much simpler and we deleted lots of lines of code 💅
The result is that it should be much lighter and hopefully much more performant.
110 lines
3.7 KiB
Go
110 lines
3.7 KiB
Go
package jetstream
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/getsentry/sentry-go"
|
|
"github.com/nats-io/nats.go"
|
|
"github.com/sirupsen/logrus"
|
|
)
|
|
|
|
// JetStreamConsumer starts a durable consumer on the given subject with the
|
|
// given durable name. The function will be called when one or more messages
|
|
// is available, up to the maximum batch size specified. If the batch is set to
|
|
// 1 then messages will be delivered one at a time. If the function is called,
|
|
// the messages array is guaranteed to be at least 1 in size. Any provided NATS
|
|
// options will be passed through to the pull subscriber creation. The consumer
|
|
// will continue to run until the context expires, at which point it will stop.
|
|
func JetStreamConsumer(
|
|
ctx context.Context, js nats.JetStreamContext, subj, durable string, batch int,
|
|
f func(ctx context.Context, msgs []*nats.Msg) bool,
|
|
opts ...nats.SubOpt,
|
|
) error {
|
|
defer func() {
|
|
// If there are existing consumers from before they were pull
|
|
// consumers, we need to clean up the old push consumers. However,
|
|
// in order to not affect the interest-based policies, we need to
|
|
// do this *after* creating the new pull consumers, which have
|
|
// "Pull" suffixed to their name.
|
|
if _, err := js.ConsumerInfo(subj, durable); err == nil {
|
|
if err := js.DeleteConsumer(subj, durable); err != nil {
|
|
logrus.WithContext(ctx).Warnf("Failed to clean up old consumer %q", durable)
|
|
}
|
|
}
|
|
}()
|
|
|
|
name := durable + "Pull"
|
|
sub, err := js.PullSubscribe(subj, name, opts...)
|
|
if err != nil {
|
|
sentry.CaptureException(err)
|
|
return fmt.Errorf("nats.SubscribeSync: %w", err)
|
|
}
|
|
go func() {
|
|
for {
|
|
// If the parent context has given up then there's no point in
|
|
// carrying on doing anything, so stop the listener.
|
|
select {
|
|
case <-ctx.Done():
|
|
if err := sub.Unsubscribe(); err != nil {
|
|
logrus.WithContext(ctx).Warnf("Failed to unsubscribe %q", durable)
|
|
}
|
|
return
|
|
default:
|
|
}
|
|
// The context behaviour here is surprising — we supply a context
|
|
// so that we can interrupt the fetch if we want, but NATS will still
|
|
// enforce its own deadline (roughly 5 seconds by default). Therefore
|
|
// it is our responsibility to check whether our context expired or
|
|
// not when a context error is returned. Footguns. Footguns everywhere.
|
|
msgs, err := sub.Fetch(batch, nats.Context(ctx))
|
|
if err != nil {
|
|
if err == context.Canceled || err == context.DeadlineExceeded {
|
|
// Work out whether it was the JetStream context that expired
|
|
// or whether it was our supplied context.
|
|
select {
|
|
case <-ctx.Done():
|
|
// The supplied context expired, so we want to stop the
|
|
// consumer altogether.
|
|
return
|
|
default:
|
|
// The JetStream context expired, so the fetch probably
|
|
// just timed out and we should try again.
|
|
continue
|
|
}
|
|
} else {
|
|
// Something else went wrong, so we'll panic.
|
|
sentry.CaptureException(err)
|
|
logrus.WithContext(ctx).WithField("subject", subj).Fatal(err)
|
|
}
|
|
}
|
|
if len(msgs) < 1 {
|
|
continue
|
|
}
|
|
for _, msg := range msgs {
|
|
if err = msg.InProgress(nats.Context(ctx)); err != nil {
|
|
logrus.WithContext(ctx).WithField("subject", subj).Warn(fmt.Errorf("msg.InProgress: %w", err))
|
|
sentry.CaptureException(err)
|
|
continue
|
|
}
|
|
}
|
|
if f(ctx, msgs) {
|
|
for _, msg := range msgs {
|
|
if err = msg.AckSync(nats.Context(ctx)); err != nil {
|
|
logrus.WithContext(ctx).WithField("subject", subj).Warn(fmt.Errorf("msg.AckSync: %w", err))
|
|
sentry.CaptureException(err)
|
|
}
|
|
}
|
|
} else {
|
|
for _, msg := range msgs {
|
|
if err = msg.Nak(nats.Context(ctx)); err != nil {
|
|
logrus.WithContext(ctx).WithField("subject", subj).Warn(fmt.Errorf("msg.Nak: %w", err))
|
|
sentry.CaptureException(err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}()
|
|
return nil
|
|
}
|