mirror of
https://github.com/matrix-org/dendrite.git
synced 2024-11-29 17:51:56 -06:00
f93d1c4790
Fixes https://github.com/matrix-org/dendrite/issues/3240 and potentially a root cause for state resets. While testing, I've had added some more debug logging: ``` time="2023-12-16T18:13:11.319458084Z" level=warning msg="already processed event" event_id="$qFYMl_F2vb1N0yxmvlFAMhqhGhLKq4kA-o_YCQKH7tQ" kind=KindNew times=2 time="2023-12-16T18:13:14.537389126Z" level=warning msg="already processed event" event_id="$EU-LTsKErT6Mt1k12-p_3xOHfiLaK6gtwVDlZ35lSuo" kind=KindNew times=5 time="2023-12-16T18:13:16.789551206Z" level=warning msg="already processed event" event_id="$dIPuAfTL5x0VyG873LKPslQeljCSxFT1WKxUtjIMUGE" kind=KindNew times=5 time="2023-12-16T18:13:17.383838767Z" level=warning msg="already processed event" event_id="$7noSZiCkzerpkz_UBO3iatpRnaOiPx-3IXc0GPDQVGE" kind=KindNew times=2 time="2023-12-16T18:13:22.091946597Z" level=warning msg="already processed event" event_id="$3Lvo3Wbi2ol9-nNbQ93N-E2MuGQCJZo5397KkFH-W6E" kind=KindNew times=1 time="2023-12-16T18:13:23.026417446Z" level=warning msg="already processed event" event_id="$lj1xS46zsLBCChhKOLJEG-bu7z-_pq9i_Y2DUIjzGy4" kind=KindNew times=4 ``` So we did receive the same event over and over again. Given they are `KindNew`, we don't short circuit if we already processed them, which potentially caused the state to be calculated with a now wrong state snapshot. Also fixes the back pressure metric. We now correctly increment the counter once we sent the message to NATS and decrement it once we actually processed an event.
973 lines
35 KiB
Go
973 lines
35 KiB
Go
// Copyright 2017 Vector Creations Ltd
|
|
// Copyright 2018 New Vector Ltd
|
|
// Copyright 2019-2020 The Matrix.org Foundation C.I.C.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package input
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/tidwall/gjson"
|
|
|
|
"github.com/matrix-org/gomatrixserverlib"
|
|
"github.com/matrix-org/gomatrixserverlib/fclient"
|
|
"github.com/matrix-org/gomatrixserverlib/spec"
|
|
"github.com/matrix-org/util"
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
"github.com/sirupsen/logrus"
|
|
|
|
"github.com/matrix-org/dendrite/roomserver/acls"
|
|
"github.com/matrix-org/dendrite/roomserver/internal/helpers"
|
|
|
|
userAPI "github.com/matrix-org/dendrite/userapi/api"
|
|
|
|
fedapi "github.com/matrix-org/dendrite/federationapi/api"
|
|
"github.com/matrix-org/dendrite/internal"
|
|
"github.com/matrix-org/dendrite/internal/eventutil"
|
|
"github.com/matrix-org/dendrite/internal/hooks"
|
|
"github.com/matrix-org/dendrite/internal/sqlutil"
|
|
"github.com/matrix-org/dendrite/roomserver/api"
|
|
"github.com/matrix-org/dendrite/roomserver/state"
|
|
"github.com/matrix-org/dendrite/roomserver/types"
|
|
)
|
|
|
|
// MaximumMissingProcessingTime is the maximum time we allow "processRoomEvent" to fetch
|
|
// e.g. missing auth/prev events. This duration is used for AckWait, and if it is exceeded
|
|
// NATS queues the event for redelivery.
|
|
const MaximumMissingProcessingTime = time.Minute * 5
|
|
|
|
var processRoomEventDuration = prometheus.NewHistogramVec(
|
|
prometheus.HistogramOpts{
|
|
Namespace: "dendrite",
|
|
Subsystem: "roomserver",
|
|
Name: "processroomevent_duration_millis",
|
|
Help: "How long it takes the roomserver to process an event",
|
|
Buckets: []float64{ // milliseconds
|
|
5, 10, 25, 50, 75, 100, 250, 500,
|
|
1000, 2000, 3000, 4000, 5000, 6000,
|
|
7000, 8000, 9000, 10000, 15000, 20000,
|
|
},
|
|
},
|
|
[]string{"room_id"},
|
|
)
|
|
|
|
// processRoomEvent can only be called once at a time
|
|
//
|
|
// TODO(#375): This should be rewritten to allow concurrent calls. The
|
|
// difficulty is in ensuring that we correctly annotate events with the correct
|
|
// state deltas when sending to kafka streams
|
|
// TODO: Break up function - we should probably do transaction ID checks before calling this.
|
|
// nolint:gocyclo
|
|
func (r *Inputer) processRoomEvent(
|
|
ctx context.Context,
|
|
virtualHost spec.ServerName,
|
|
input *api.InputRoomEvent,
|
|
) error {
|
|
select {
|
|
case <-ctx.Done():
|
|
// Before we do anything, make sure the context hasn't expired for this pending task.
|
|
// If it has then we'll give up straight away — it's probably a synchronous input
|
|
// request and the caller has already given up, but the inbox task was still queued.
|
|
return context.DeadlineExceeded
|
|
default:
|
|
}
|
|
|
|
trace, ctx := internal.StartRegion(ctx, "processRoomEvent")
|
|
trace.SetTag("room_id", input.Event.RoomID().String())
|
|
trace.SetTag("event_id", input.Event.EventID())
|
|
defer trace.EndRegion()
|
|
|
|
// Measure how long it takes to process this event.
|
|
started := time.Now()
|
|
defer func() {
|
|
timetaken := time.Since(started)
|
|
processRoomEventDuration.With(prometheus.Labels{
|
|
"room_id": input.Event.RoomID().String(),
|
|
}).Observe(float64(timetaken.Milliseconds()))
|
|
}()
|
|
|
|
// Parse and validate the event JSON
|
|
headered := input.Event
|
|
event := headered.PDU
|
|
logger := util.GetLogger(ctx).WithFields(logrus.Fields{
|
|
"event_id": event.EventID(),
|
|
"room_id": event.RoomID().String(),
|
|
"kind": input.Kind,
|
|
"origin": input.Origin,
|
|
"type": event.Type(),
|
|
})
|
|
if input.HasState {
|
|
logger = logger.WithFields(logrus.Fields{
|
|
"has_state": input.HasState,
|
|
"state_ids": len(input.StateEventIDs),
|
|
})
|
|
}
|
|
|
|
// Don't waste time processing the event if the room doesn't exist.
|
|
// A room entry locally will only be created in response to a create
|
|
// event.
|
|
roomInfo, rerr := r.DB.RoomInfo(ctx, event.RoomID().String())
|
|
if rerr != nil {
|
|
return fmt.Errorf("r.DB.RoomInfo: %w", rerr)
|
|
}
|
|
isCreateEvent := event.Type() == spec.MRoomCreate && event.StateKeyEquals("")
|
|
if roomInfo == nil && !isCreateEvent {
|
|
return fmt.Errorf("room %s does not exist for event %s", event.RoomID().String(), event.EventID())
|
|
}
|
|
sender, err := r.Queryer.QueryUserIDForSender(ctx, event.RoomID(), event.SenderID())
|
|
if err != nil {
|
|
return fmt.Errorf("failed getting userID for sender %q. %w", event.SenderID(), err)
|
|
}
|
|
senderDomain := spec.ServerName("")
|
|
if sender != nil {
|
|
senderDomain = sender.Domain()
|
|
}
|
|
|
|
// If we already know about this outlier and it hasn't been rejected
|
|
// then we won't attempt to reprocess it. If it was rejected or has now
|
|
// arrived as a different kind of event, then we can attempt to reprocess,
|
|
// in case we have learned something new or need to weave the event into
|
|
// the DAG now.
|
|
if input.Kind == api.KindOutlier && roomInfo != nil {
|
|
wasRejected, werr := r.DB.IsEventRejected(ctx, roomInfo.RoomNID, event.EventID())
|
|
switch {
|
|
case werr == sql.ErrNoRows:
|
|
// We haven't seen this event before so continue.
|
|
case werr != nil:
|
|
// Something has gone wrong trying to find out if we rejected
|
|
// this event already.
|
|
logger.WithError(werr).Errorf("Failed to check if event %q is already seen", event.EventID())
|
|
return werr
|
|
case !wasRejected:
|
|
// We've seen this event before and it wasn't rejected so we
|
|
// should ignore it.
|
|
logger.Debugf("Already processed event %q, ignoring", event.EventID())
|
|
return nil
|
|
}
|
|
}
|
|
|
|
var missingAuth, missingPrev bool
|
|
serverRes := &fedapi.QueryJoinedHostServerNamesInRoomResponse{}
|
|
if !isCreateEvent {
|
|
var missingAuthIDs, missingPrevIDs []string
|
|
missingAuthIDs, missingPrevIDs, err = r.DB.MissingAuthPrevEvents(ctx, event)
|
|
if err != nil {
|
|
return fmt.Errorf("updater.MissingAuthPrevEvents: %w", err)
|
|
}
|
|
missingAuth = len(missingAuthIDs) > 0
|
|
missingPrev = !input.HasState && len(missingPrevIDs) > 0
|
|
}
|
|
|
|
// If we have missing events (auth or prev), we build a list of servers to ask
|
|
if missingAuth || missingPrev {
|
|
serverReq := &fedapi.QueryJoinedHostServerNamesInRoomRequest{
|
|
RoomID: event.RoomID().String(),
|
|
ExcludeSelf: true,
|
|
ExcludeBlacklisted: true,
|
|
}
|
|
if err = r.FSAPI.QueryJoinedHostServerNamesInRoom(ctx, serverReq, serverRes); err != nil {
|
|
return fmt.Errorf("r.FSAPI.QueryJoinedHostServerNamesInRoom: %w", err)
|
|
}
|
|
// Sort all of the servers into a map so that we can randomise
|
|
// their order. Then make sure that the input origin and the
|
|
// event origin are first on the list.
|
|
servers := map[spec.ServerName]struct{}{}
|
|
for _, server := range serverRes.ServerNames {
|
|
servers[server] = struct{}{}
|
|
}
|
|
// Don't try to talk to ourselves.
|
|
delete(servers, r.Cfg.Matrix.ServerName)
|
|
// Now build up the list of servers.
|
|
serverRes.ServerNames = serverRes.ServerNames[:0]
|
|
if input.Origin != "" && input.Origin != r.Cfg.Matrix.ServerName {
|
|
serverRes.ServerNames = append(serverRes.ServerNames, input.Origin)
|
|
delete(servers, input.Origin)
|
|
}
|
|
// Only perform this check if the sender mxid_mapping can be resolved.
|
|
// Don't fail processing the event if we have no mxid_maping.
|
|
if sender != nil && senderDomain != input.Origin && senderDomain != r.Cfg.Matrix.ServerName {
|
|
serverRes.ServerNames = append(serverRes.ServerNames, senderDomain)
|
|
delete(servers, senderDomain)
|
|
}
|
|
for server := range servers {
|
|
serverRes.ServerNames = append(serverRes.ServerNames, server)
|
|
delete(servers, server)
|
|
}
|
|
}
|
|
|
|
isRejected := false
|
|
var rejectionErr error
|
|
|
|
// At this point we are checking whether we know all of the prev events, and
|
|
// if we know the state before the prev events. This is necessary before we
|
|
// try to do `calculateAndSetState` on the event later, otherwise it will fail
|
|
// with missing event NIDs. If there's anything missing then we'll go and fetch
|
|
// the prev events and state from the federation. Note that we only do this if
|
|
// we weren't already told what the state before the event should be — if the
|
|
// HasState option was set and a state set was provided (as is the case in a
|
|
// typical federated room join) then we won't bother trying to fetch prev events
|
|
// because we may not be allowed to see them and we have no choice but to trust
|
|
// the state event IDs provided to us in the join instead.
|
|
if missingPrev && input.Kind == api.KindNew {
|
|
// Don't do this for KindOld events, otherwise old events that we fetch
|
|
// to satisfy missing prev events/state will end up recursively calling
|
|
// processRoomEvent.
|
|
if len(serverRes.ServerNames) > 0 {
|
|
missingState := missingStateReq{
|
|
origin: input.Origin,
|
|
virtualHost: virtualHost,
|
|
inputer: r,
|
|
db: r.DB,
|
|
roomInfo: roomInfo,
|
|
federation: r.FSAPI,
|
|
keys: r.KeyRing,
|
|
roomsMu: internal.NewMutexByRoom(),
|
|
servers: serverRes.ServerNames,
|
|
hadEvents: map[string]bool{},
|
|
haveEvents: map[string]gomatrixserverlib.PDU{},
|
|
}
|
|
var stateSnapshot *parsedRespState
|
|
if stateSnapshot, err = missingState.processEventWithMissingState(ctx, event, headered.Version()); err != nil {
|
|
// Something went wrong with retrieving the missing state, so we can't
|
|
// really do anything with the event other than reject it at this point.
|
|
isRejected = true
|
|
rejectionErr = fmt.Errorf("missingState.processEventWithMissingState: %w", err)
|
|
switch e := err.(type) {
|
|
case gomatrixserverlib.EventValidationError:
|
|
if e.Persistable && stateSnapshot != nil {
|
|
// We retrieved some state and we ended up having to call /state_ids for
|
|
// the new event in question (probably because closing the gap by using
|
|
// /get_missing_events didn't do what we hoped) so we'll instead overwrite
|
|
// the state snapshot with the newly resolved state.
|
|
missingPrev = false
|
|
input.HasState = true
|
|
input.StateEventIDs = make([]string, 0, len(stateSnapshot.StateEvents))
|
|
for _, se := range stateSnapshot.StateEvents {
|
|
input.StateEventIDs = append(input.StateEventIDs, se.EventID())
|
|
}
|
|
}
|
|
}
|
|
} else if stateSnapshot != nil {
|
|
// We retrieved some state and we ended up having to call /state_ids for
|
|
// the new event in question (probably because closing the gap by using
|
|
// /get_missing_events didn't do what we hoped) so we'll instead overwrite
|
|
// the state snapshot with the newly resolved state.
|
|
missingPrev = false
|
|
input.HasState = true
|
|
input.StateEventIDs = make([]string, 0, len(stateSnapshot.StateEvents))
|
|
for _, e := range stateSnapshot.StateEvents {
|
|
input.StateEventIDs = append(input.StateEventIDs, e.EventID())
|
|
}
|
|
} else {
|
|
// We retrieved some state and it would appear that rolling forward the
|
|
// state did everything we needed it to do, so we can just resolve the
|
|
// state for the event in the normal way.
|
|
missingPrev = false
|
|
}
|
|
} else {
|
|
// We're missing prev events or state for the event, but for some reason
|
|
// we don't know any servers to ask. In this case we can't do anything but
|
|
// reject the event and hope that it gets unrejected later.
|
|
isRejected = true
|
|
rejectionErr = fmt.Errorf("missing prev events and no other servers to ask")
|
|
}
|
|
}
|
|
|
|
// Check that the auth events of the event are known.
|
|
// If they aren't then we will ask the federation API for them.
|
|
authEvents := gomatrixserverlib.NewAuthEvents(nil)
|
|
knownEvents := map[string]*types.Event{}
|
|
if err = r.fetchAuthEvents(ctx, logger, roomInfo, virtualHost, headered, &authEvents, knownEvents, serverRes.ServerNames); err != nil {
|
|
return fmt.Errorf("r.fetchAuthEvents: %w", err)
|
|
}
|
|
|
|
// Check if the event is allowed by its auth events. If it isn't then
|
|
// we consider the event to be "rejected" — it will still be persisted.
|
|
if err = gomatrixserverlib.Allowed(event, &authEvents, func(roomID spec.RoomID, senderID spec.SenderID) (*spec.UserID, error) {
|
|
return r.Queryer.QueryUserIDForSender(ctx, roomID, senderID)
|
|
}); err != nil {
|
|
isRejected = true
|
|
rejectionErr = err
|
|
logger.WithError(rejectionErr).Warnf("Event %s not allowed by auth events", event.EventID())
|
|
}
|
|
|
|
// Accumulate the auth event NIDs.
|
|
authEventIDs := event.AuthEventIDs()
|
|
authEventNIDs := make([]types.EventNID, 0, len(authEventIDs))
|
|
for _, authEventID := range authEventIDs {
|
|
if _, ok := knownEvents[authEventID]; !ok {
|
|
// Unknown auth events only really matter if the event actually failed
|
|
// auth. If it passed auth then we can assume that everything that was
|
|
// known was sufficient, even if extraneous auth events were specified
|
|
// but weren't found.
|
|
if isRejected {
|
|
if event.StateKey() != nil {
|
|
return fmt.Errorf(
|
|
"missing auth event %s for state event %s (type %q, state key %q)",
|
|
authEventID, event.EventID(), event.Type(), *event.StateKey(),
|
|
)
|
|
} else {
|
|
return fmt.Errorf(
|
|
"missing auth event %s for timeline event %s (type %q)",
|
|
authEventID, event.EventID(), event.Type(),
|
|
)
|
|
}
|
|
}
|
|
} else {
|
|
authEventNIDs = append(authEventNIDs, knownEvents[authEventID].EventNID)
|
|
}
|
|
}
|
|
|
|
var softfail bool
|
|
if input.Kind == api.KindNew && !isCreateEvent {
|
|
// Check that the event passes authentication checks based on the
|
|
// current room state.
|
|
softfail, err = helpers.CheckForSoftFail(ctx, r.DB, roomInfo, headered, input.StateEventIDs, r.Queryer)
|
|
if err != nil {
|
|
logger.WithError(err).Warn("Error authing soft-failed event")
|
|
}
|
|
}
|
|
|
|
// Get the state before the event so that we can work out if the event was
|
|
// allowed at the time, and also to get the history visibility. We won't
|
|
// bother doing this if the event was already rejected as it just ends up
|
|
// burning CPU time.
|
|
historyVisibility := gomatrixserverlib.HistoryVisibilityShared // Default to shared.
|
|
if input.Kind != api.KindOutlier && rejectionErr == nil && !isRejected && !isCreateEvent {
|
|
historyVisibility, rejectionErr, err = r.processStateBefore(ctx, roomInfo, input, missingPrev)
|
|
if err != nil {
|
|
return fmt.Errorf("r.processStateBefore: %w", err)
|
|
}
|
|
if rejectionErr != nil {
|
|
isRejected = true
|
|
}
|
|
}
|
|
|
|
if roomInfo == nil {
|
|
roomInfo, err = r.DB.GetOrCreateRoomInfo(ctx, event)
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateRoomInfo: %w", err)
|
|
}
|
|
}
|
|
|
|
eventTypeNID, err := r.DB.GetOrCreateEventTypeNID(ctx, event.Type())
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateEventTypeNID: %w", err)
|
|
}
|
|
|
|
eventStateKeyNID, err := r.DB.GetOrCreateEventStateKeyNID(ctx, event.StateKey())
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateEventStateKeyNID: %w", err)
|
|
}
|
|
|
|
// Store the event.
|
|
eventNID, stateAtEvent, err := r.DB.StoreEvent(ctx, event, roomInfo, eventTypeNID, eventStateKeyNID, authEventNIDs, isRejected)
|
|
if err != nil {
|
|
return fmt.Errorf("updater.StoreEvent: %w", err)
|
|
}
|
|
|
|
// For outliers we can stop after we've stored the event itself as it
|
|
// doesn't have any associated state to store and we don't need to
|
|
// notify anyone about it.
|
|
if input.Kind == api.KindOutlier {
|
|
logger.WithField("rejected", isRejected).Debug("Stored outlier")
|
|
hooks.Run(hooks.KindNewEventPersisted, headered)
|
|
return nil
|
|
}
|
|
|
|
// Request the room info again — it's possible that the room has been
|
|
// created by now if it didn't exist already.
|
|
roomInfo, err = r.DB.RoomInfo(ctx, event.RoomID().String())
|
|
if err != nil {
|
|
return fmt.Errorf("updater.RoomInfo: %w", err)
|
|
}
|
|
if roomInfo == nil {
|
|
return fmt.Errorf("updater.RoomInfo missing for room %s", event.RoomID().String())
|
|
}
|
|
|
|
if input.HasState || (!missingPrev && stateAtEvent.BeforeStateSnapshotNID == 0) {
|
|
// We haven't calculated a state for this event yet.
|
|
// Lets calculate one.
|
|
err = r.calculateAndSetState(ctx, input, roomInfo, &stateAtEvent, event, isRejected)
|
|
if err != nil {
|
|
return fmt.Errorf("r.calculateAndSetState: %w", err)
|
|
}
|
|
}
|
|
|
|
// if storing this event results in it being redacted then do so.
|
|
// we do this after calculating state for this event as we may need to get power levels
|
|
var (
|
|
redactedEventID string
|
|
redactionEvent gomatrixserverlib.PDU
|
|
redactedEvent gomatrixserverlib.PDU
|
|
)
|
|
if !isRejected && !isCreateEvent {
|
|
resolver := state.NewStateResolution(r.DB, roomInfo, r.Queryer)
|
|
redactionEvent, redactedEvent, err = r.DB.MaybeRedactEvent(ctx, roomInfo, eventNID, event, &resolver, r.Queryer)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if redactedEvent != nil {
|
|
redactedEventID = redactedEvent.EventID()
|
|
}
|
|
}
|
|
|
|
// We stop here if the event is rejected: We've stored it but won't update
|
|
// forward extremities or notify downstream components about it.
|
|
switch {
|
|
case isRejected:
|
|
logger.WithError(rejectionErr).Warn("Stored rejected event")
|
|
if rejectionErr != nil {
|
|
return types.RejectedError(rejectionErr.Error())
|
|
}
|
|
return nil
|
|
|
|
case softfail:
|
|
logger.WithError(rejectionErr).Warn("Stored soft-failed event")
|
|
if rejectionErr != nil {
|
|
return types.RejectedError(rejectionErr.Error())
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// TODO: Revist this to ensure we don't replace a current state mxid_mapping with an older one.
|
|
if event.Version() == gomatrixserverlib.RoomVersionPseudoIDs && event.Type() == spec.MRoomMember {
|
|
mapping := gomatrixserverlib.MemberContent{}
|
|
if err = json.Unmarshal(event.Content(), &mapping); err != nil {
|
|
return err
|
|
}
|
|
if mapping.MXIDMapping != nil {
|
|
storeUserID, userErr := spec.NewUserID(mapping.MXIDMapping.UserID, true)
|
|
if userErr != nil {
|
|
return userErr
|
|
}
|
|
err = r.RSAPI.StoreUserRoomPublicKey(ctx, mapping.MXIDMapping.UserRoomKey, *storeUserID, event.RoomID())
|
|
if err != nil {
|
|
return fmt.Errorf("failed storing user room public key: %w", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
switch input.Kind {
|
|
case api.KindNew:
|
|
if err = r.updateLatestEvents(
|
|
ctx, // context
|
|
roomInfo, // room info for the room being updated
|
|
stateAtEvent, // state at event (below)
|
|
event, // event
|
|
input.SendAsServer, // send as server
|
|
input.TransactionID, // transaction ID
|
|
input.HasState, // rewrites state?
|
|
historyVisibility, // the history visibility before the event
|
|
); err != nil {
|
|
return fmt.Errorf("r.updateLatestEvents: %w", err)
|
|
}
|
|
case api.KindOld:
|
|
err = r.OutputProducer.ProduceRoomEvents(event.RoomID().String(), []api.OutputEvent{
|
|
{
|
|
Type: api.OutputTypeOldRoomEvent,
|
|
OldRoomEvent: &api.OutputOldRoomEvent{
|
|
Event: headered,
|
|
HistoryVisibility: historyVisibility,
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("r.WriteOutputEvents (old): %w", err)
|
|
}
|
|
}
|
|
|
|
// If this is a membership event, it is possible we newly joined a federated room and eventually
|
|
// missed to update our m.room.server_acl - the following ensures we set the ACLs
|
|
// TODO: This probably performs badly in benchmarks
|
|
if event.Type() == spec.MRoomMember {
|
|
membership, _ := event.Membership()
|
|
if membership == spec.Join {
|
|
_, serverName, _ := gomatrixserverlib.SplitID('@', *event.StateKey())
|
|
// only handle local membership events
|
|
if r.Cfg.Matrix.IsLocalServerName(serverName) {
|
|
var aclEvent *types.HeaderedEvent
|
|
aclEvent, err = r.DB.GetStateEvent(ctx, event.RoomID().String(), acls.MRoomServerACL, "")
|
|
if err != nil {
|
|
logrus.WithError(err).Error("failed to get server ACLs")
|
|
}
|
|
if aclEvent != nil {
|
|
r.ACLs.OnServerACLUpdate(aclEvent)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// Handle remote room upgrades, e.g. remove published room
|
|
if event.Type() == "m.room.tombstone" && event.StateKeyEquals("") && !r.Cfg.Matrix.IsLocalServerName(senderDomain) {
|
|
if err = r.handleRemoteRoomUpgrade(ctx, event); err != nil {
|
|
return fmt.Errorf("failed to handle remote room upgrade: %w", err)
|
|
}
|
|
}
|
|
|
|
// processing this event resulted in an event (which may not be the one we're processing)
|
|
// being redacted. We are guaranteed to have both sides (the redaction/redacted event),
|
|
// so notify downstream components to redact this event - they should have it if they've
|
|
// been tracking our output log.
|
|
if redactedEventID != "" {
|
|
err = r.OutputProducer.ProduceRoomEvents(event.RoomID().String(), []api.OutputEvent{
|
|
{
|
|
Type: api.OutputTypeRedactedEvent,
|
|
RedactedEvent: &api.OutputRedactedEvent{
|
|
RedactedEventID: redactedEventID,
|
|
RedactedBecause: &types.HeaderedEvent{PDU: redactionEvent},
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
return fmt.Errorf("r.WriteOutputEvents (redactions): %w", err)
|
|
}
|
|
}
|
|
|
|
// If guest_access changed and is not can_join, kick all guest users.
|
|
if event.Type() == spec.MRoomGuestAccess && gjson.GetBytes(event.Content(), "guest_access").Str != "can_join" {
|
|
if err = r.kickGuests(ctx, event, roomInfo); err != nil && err != sql.ErrNoRows {
|
|
logrus.WithError(err).Error("failed to kick guest users on m.room.guest_access revocation")
|
|
}
|
|
}
|
|
|
|
// Everything was OK — the latest events updater didn't error and
|
|
// we've sent output events. Finally, generate a hook call.
|
|
hooks.Run(hooks.KindNewEventPersisted, headered)
|
|
return nil
|
|
}
|
|
|
|
// handleRemoteRoomUpgrade updates published rooms and room aliases
|
|
func (r *Inputer) handleRemoteRoomUpgrade(ctx context.Context, event gomatrixserverlib.PDU) error {
|
|
oldRoomID := event.RoomID().String()
|
|
newRoomID := gjson.GetBytes(event.Content(), "replacement_room").Str
|
|
return r.DB.UpgradeRoom(ctx, oldRoomID, newRoomID, string(event.SenderID()))
|
|
}
|
|
|
|
// processStateBefore works out what the state is before the event and
|
|
// then checks the event auths against the state at the time. It also
|
|
// tries to determine what the history visibility was of the event at
|
|
// the time, so that it can be sent in the output event to downstream
|
|
// components.
|
|
// nolint:nakedret
|
|
func (r *Inputer) processStateBefore(
|
|
ctx context.Context,
|
|
roomInfo *types.RoomInfo,
|
|
input *api.InputRoomEvent,
|
|
missingPrev bool,
|
|
) (historyVisibility gomatrixserverlib.HistoryVisibility, rejectionErr error, err error) {
|
|
historyVisibility = gomatrixserverlib.HistoryVisibilityShared // Default to shared.
|
|
event := input.Event.PDU
|
|
isCreateEvent := event.Type() == spec.MRoomCreate && event.StateKeyEquals("")
|
|
var stateBeforeEvent []gomatrixserverlib.PDU
|
|
switch {
|
|
case isCreateEvent:
|
|
// There's no state before a create event so there is nothing
|
|
// else to do.
|
|
return
|
|
case input.HasState:
|
|
// If we're overriding the state then we need to go and retrieve
|
|
// them from the database. It's a hard error if they are missing.
|
|
stateEvents, err := r.DB.EventsFromIDs(ctx, roomInfo, input.StateEventIDs)
|
|
if err != nil {
|
|
return "", nil, fmt.Errorf("r.DB.EventsFromIDs: %w", err)
|
|
}
|
|
stateBeforeEvent = make([]gomatrixserverlib.PDU, 0, len(stateEvents))
|
|
for _, entry := range stateEvents {
|
|
stateBeforeEvent = append(stateBeforeEvent, entry.PDU)
|
|
}
|
|
case missingPrev:
|
|
// We don't know all of the prev events, so we can't work out
|
|
// the state before the event. Reject it in that case.
|
|
rejectionErr = fmt.Errorf("event %q has missing prev events", event.EventID())
|
|
return
|
|
case len(event.PrevEventIDs()) == 0:
|
|
// There should be prev events since it's not a create event.
|
|
// A non-create event that claims to have no prev events is
|
|
// invalid, so reject it.
|
|
rejectionErr = fmt.Errorf("event %q must have prev events", event.EventID())
|
|
return
|
|
default:
|
|
// For all non-create events, there must be prev events, so we'll
|
|
// ask the query API for the relevant tuples needed for auth. We
|
|
// will include the history visibility here even though we don't
|
|
// actually need it for auth, because we want to send it in the
|
|
// output events.
|
|
tuplesNeeded := gomatrixserverlib.StateNeededForAuth([]gomatrixserverlib.PDU{event}).Tuples()
|
|
tuplesNeeded = append(tuplesNeeded, gomatrixserverlib.StateKeyTuple{
|
|
EventType: spec.MRoomHistoryVisibility,
|
|
StateKey: "",
|
|
})
|
|
stateBeforeReq := &api.QueryStateAfterEventsRequest{
|
|
RoomID: event.RoomID().String(),
|
|
PrevEventIDs: event.PrevEventIDs(),
|
|
StateToFetch: tuplesNeeded,
|
|
}
|
|
stateBeforeRes := &api.QueryStateAfterEventsResponse{}
|
|
if err := r.Queryer.QueryStateAfterEvents(ctx, stateBeforeReq, stateBeforeRes); err != nil {
|
|
return "", nil, fmt.Errorf("r.Queryer.QueryStateAfterEvents: %w", err)
|
|
}
|
|
switch {
|
|
case !stateBeforeRes.RoomExists:
|
|
rejectionErr = fmt.Errorf("room %q does not exist", event.RoomID().String())
|
|
return
|
|
case !stateBeforeRes.PrevEventsExist:
|
|
rejectionErr = fmt.Errorf("prev events of %q are not known", event.EventID())
|
|
return
|
|
default:
|
|
stateBeforeEvent = make([]gomatrixserverlib.PDU, len(stateBeforeRes.StateEvents))
|
|
for i := range stateBeforeRes.StateEvents {
|
|
stateBeforeEvent[i] = stateBeforeRes.StateEvents[i].PDU
|
|
}
|
|
}
|
|
}
|
|
// At this point, stateBeforeEvent should be populated either by
|
|
// the supplied state in the input request, or from the prev events.
|
|
// Check whether the event is allowed or not.
|
|
stateBeforeAuth := gomatrixserverlib.NewAuthEvents(
|
|
gomatrixserverlib.ToPDUs(stateBeforeEvent),
|
|
)
|
|
if rejectionErr = gomatrixserverlib.Allowed(event, &stateBeforeAuth, func(roomID spec.RoomID, senderID spec.SenderID) (*spec.UserID, error) {
|
|
return r.Queryer.QueryUserIDForSender(ctx, roomID, senderID)
|
|
}); rejectionErr != nil {
|
|
rejectionErr = fmt.Errorf("Allowed() failed for stateBeforeEvent: %w", rejectionErr)
|
|
return
|
|
}
|
|
// Work out what the history visibility was at the time of the
|
|
// event.
|
|
for _, event := range stateBeforeEvent {
|
|
if event.Type() != spec.MRoomHistoryVisibility || !event.StateKeyEquals("") {
|
|
continue
|
|
}
|
|
if hisVis, err := event.HistoryVisibility(); err == nil {
|
|
historyVisibility = hisVis
|
|
break
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
// fetchAuthEvents will check to see if any of the
|
|
// auth events specified by the given event are unknown. If they are
|
|
// then we will go off and request them from the federation and then
|
|
// store them in the database. By the time this function ends, either
|
|
// we've failed to retrieve the auth chain altogether (in which case
|
|
// an error is returned) or we've successfully retrieved them all and
|
|
// they are now in the database.
|
|
// nolint: gocyclo
|
|
func (r *Inputer) fetchAuthEvents(
|
|
ctx context.Context,
|
|
logger *logrus.Entry,
|
|
roomInfo *types.RoomInfo,
|
|
virtualHost spec.ServerName,
|
|
event *types.HeaderedEvent,
|
|
auth *gomatrixserverlib.AuthEvents,
|
|
known map[string]*types.Event,
|
|
servers []spec.ServerName,
|
|
) error {
|
|
trace, ctx := internal.StartRegion(ctx, "fetchAuthEvents")
|
|
defer trace.EndRegion()
|
|
|
|
unknown := map[string]struct{}{}
|
|
authEventIDs := event.AuthEventIDs()
|
|
if len(authEventIDs) == 0 {
|
|
return nil
|
|
}
|
|
|
|
for _, authEventID := range authEventIDs {
|
|
authEvents, err := r.DB.EventsFromIDs(ctx, roomInfo, []string{authEventID})
|
|
if err != nil || len(authEvents) == 0 || authEvents[0].PDU == nil {
|
|
unknown[authEventID] = struct{}{}
|
|
continue
|
|
}
|
|
ev := authEvents[0]
|
|
|
|
isRejected := false
|
|
if roomInfo != nil {
|
|
isRejected, err = r.DB.IsEventRejected(ctx, roomInfo.RoomNID, ev.EventID())
|
|
if err != nil && !errors.Is(err, sql.ErrNoRows) {
|
|
return fmt.Errorf("r.DB.IsEventRejected failed: %w", err)
|
|
}
|
|
}
|
|
known[authEventID] = &ev // don't take the pointer of the iterated event
|
|
if !isRejected {
|
|
if err = auth.AddEvent(ev.PDU); err != nil {
|
|
return fmt.Errorf("auth.AddEvent: %w", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// If there are no missing auth events then there is nothing more
|
|
// to do — we've loaded everything that we need.
|
|
if len(unknown) == 0 {
|
|
return nil
|
|
}
|
|
|
|
var err error
|
|
var res fclient.RespEventAuth
|
|
var found bool
|
|
for _, serverName := range servers {
|
|
// Request the entire auth chain for the event in question. This should
|
|
// contain all of the auth events — including ones that we already know —
|
|
// so we'll need to filter through those in the next section.
|
|
res, err = r.FSAPI.GetEventAuth(ctx, virtualHost, serverName, event.Version(), event.RoomID().String(), event.EventID())
|
|
if err != nil {
|
|
logger.WithError(err).Warnf("Failed to get event auth from federation for %q: %s", event.EventID(), err)
|
|
continue
|
|
}
|
|
found = true
|
|
break
|
|
}
|
|
if !found {
|
|
return fmt.Errorf("no servers provided event auth for event ID %q, tried servers %v", event.EventID(), servers)
|
|
}
|
|
|
|
// Reuse these to reduce allocations.
|
|
authEventNIDs := make([]types.EventNID, 0, 5)
|
|
isRejected := false
|
|
nextAuthEvent:
|
|
for _, authEvent := range gomatrixserverlib.ReverseTopologicalOrdering(
|
|
gomatrixserverlib.ToPDUs(res.AuthEvents.UntrustedEvents(event.Version())),
|
|
gomatrixserverlib.TopologicalOrderByAuthEvents,
|
|
) {
|
|
// If we already know about this event from the database then we don't
|
|
// need to store it again or do anything further with it, so just skip
|
|
// over it rather than wasting cycles.
|
|
if ev, ok := known[authEvent.EventID()]; ok && ev != nil {
|
|
continue nextAuthEvent
|
|
}
|
|
|
|
// Check the signatures of the event. If this fails then we'll simply
|
|
// skip it, because gomatrixserverlib.Allowed() will notice a problem
|
|
// if a critical event is missing anyway.
|
|
if err := gomatrixserverlib.VerifyEventSignatures(ctx, authEvent, r.FSAPI.KeyRing(), func(roomID spec.RoomID, senderID spec.SenderID) (*spec.UserID, error) {
|
|
return r.Queryer.QueryUserIDForSender(ctx, roomID, senderID)
|
|
}); err != nil {
|
|
continue nextAuthEvent
|
|
}
|
|
|
|
// In order to store the new auth event, we need to know its auth chain
|
|
// as NIDs for the `auth_event_nids` column. Let's see if we can find those.
|
|
authEventNIDs = authEventNIDs[:0]
|
|
for _, eventID := range authEvent.AuthEventIDs() {
|
|
knownEvent, ok := known[eventID]
|
|
if !ok {
|
|
continue nextAuthEvent
|
|
}
|
|
authEventNIDs = append(authEventNIDs, knownEvent.EventNID)
|
|
}
|
|
|
|
// Check if the auth event should be rejected.
|
|
err := gomatrixserverlib.Allowed(authEvent, auth, func(roomID spec.RoomID, senderID spec.SenderID) (*spec.UserID, error) {
|
|
return r.Queryer.QueryUserIDForSender(ctx, roomID, senderID)
|
|
})
|
|
if isRejected = err != nil; isRejected {
|
|
logger.WithError(err).Warnf("Auth event %s rejected", authEvent.EventID())
|
|
}
|
|
|
|
if roomInfo == nil {
|
|
roomInfo, err = r.DB.GetOrCreateRoomInfo(ctx, authEvent)
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateRoomInfo: %w", err)
|
|
}
|
|
}
|
|
|
|
eventTypeNID, err := r.DB.GetOrCreateEventTypeNID(ctx, authEvent.Type())
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateEventTypeNID: %w", err)
|
|
}
|
|
|
|
eventStateKeyNID, err := r.DB.GetOrCreateEventStateKeyNID(ctx, event.StateKey())
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetOrCreateEventStateKeyNID: %w", err)
|
|
}
|
|
|
|
// Finally, store the event in the database.
|
|
eventNID, _, err := r.DB.StoreEvent(ctx, authEvent, roomInfo, eventTypeNID, eventStateKeyNID, authEventNIDs, isRejected)
|
|
if err != nil {
|
|
return fmt.Errorf("updater.StoreEvent: %w", err)
|
|
}
|
|
|
|
// Let's take a note of the fact that we now know about this event for
|
|
// authenticating future events.
|
|
if !isRejected {
|
|
if err := auth.AddEvent(authEvent); err != nil {
|
|
return fmt.Errorf("auth.AddEvent: %w", err)
|
|
}
|
|
}
|
|
|
|
// Now we know about this event, it was stored and the signatures were OK.
|
|
known[authEvent.EventID()] = &types.Event{
|
|
EventNID: eventNID,
|
|
PDU: authEvent,
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (r *Inputer) calculateAndSetState(
|
|
ctx context.Context,
|
|
input *api.InputRoomEvent,
|
|
roomInfo *types.RoomInfo,
|
|
stateAtEvent *types.StateAtEvent,
|
|
event gomatrixserverlib.PDU,
|
|
isRejected bool,
|
|
) error {
|
|
trace, ctx := internal.StartRegion(ctx, "calculateAndSetState")
|
|
defer trace.EndRegion()
|
|
|
|
var succeeded bool
|
|
updater, err := r.DB.GetRoomUpdater(ctx, roomInfo)
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.GetRoomUpdater: %w", err)
|
|
}
|
|
defer sqlutil.EndTransactionWithCheck(updater, &succeeded, &err)
|
|
roomState := state.NewStateResolution(updater, roomInfo, r.Queryer)
|
|
|
|
if input.HasState {
|
|
// We've been told what the state at the event is so we don't need to calculate it.
|
|
// Check that those state events are in the database and store the state.
|
|
var entries []types.StateEntry
|
|
if entries, err = r.DB.StateEntriesForEventIDs(ctx, input.StateEventIDs, true); err != nil {
|
|
return fmt.Errorf("updater.StateEntriesForEventIDs: %w", err)
|
|
}
|
|
entries = types.DeduplicateStateEntries(entries)
|
|
|
|
if stateAtEvent.BeforeStateSnapshotNID, err = updater.AddState(ctx, roomInfo.RoomNID, nil, entries); err != nil {
|
|
return fmt.Errorf("updater.AddState: %w", err)
|
|
}
|
|
} else {
|
|
// We haven't been told what the state at the event is so we need to calculate it from the prev_events
|
|
if stateAtEvent.BeforeStateSnapshotNID, err = roomState.CalculateAndStoreStateBeforeEvent(ctx, event, isRejected); err != nil {
|
|
return fmt.Errorf("roomState.CalculateAndStoreStateBeforeEvent: %w", err)
|
|
}
|
|
}
|
|
|
|
err = updater.SetState(ctx, stateAtEvent.EventNID, stateAtEvent.BeforeStateSnapshotNID)
|
|
if err != nil {
|
|
return fmt.Errorf("r.DB.SetState: %w", err)
|
|
}
|
|
succeeded = true
|
|
return nil
|
|
}
|
|
|
|
// kickGuests kicks guests users from m.room.guest_access rooms, if guest access is now prohibited.
|
|
func (r *Inputer) kickGuests(ctx context.Context, event gomatrixserverlib.PDU, roomInfo *types.RoomInfo) error {
|
|
membershipNIDs, err := r.DB.GetMembershipEventNIDsForRoom(ctx, roomInfo.RoomNID, true, true)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if roomInfo == nil {
|
|
return types.ErrorInvalidRoomInfo
|
|
}
|
|
memberEvents, err := r.DB.Events(ctx, roomInfo.RoomVersion, membershipNIDs)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
inputEvents := make([]api.InputRoomEvent, 0, len(memberEvents))
|
|
latestReq := &api.QueryLatestEventsAndStateRequest{
|
|
RoomID: event.RoomID().String(),
|
|
}
|
|
latestRes := &api.QueryLatestEventsAndStateResponse{}
|
|
if err = r.Queryer.QueryLatestEventsAndState(ctx, latestReq, latestRes); err != nil {
|
|
return err
|
|
}
|
|
|
|
prevEvents := latestRes.LatestEvents
|
|
for _, memberEvent := range memberEvents {
|
|
if memberEvent.StateKey() == nil {
|
|
continue
|
|
}
|
|
|
|
memberUserID, err := r.Queryer.QueryUserIDForSender(ctx, event.RoomID(), spec.SenderID(*memberEvent.StateKey()))
|
|
if err != nil {
|
|
continue
|
|
}
|
|
|
|
accountRes := &userAPI.QueryAccountByLocalpartResponse{}
|
|
if err = r.UserAPI.QueryAccountByLocalpart(ctx, &userAPI.QueryAccountByLocalpartRequest{
|
|
Localpart: memberUserID.Local(),
|
|
ServerName: memberUserID.Domain(),
|
|
}, accountRes); err != nil {
|
|
return err
|
|
}
|
|
if accountRes.Account == nil {
|
|
continue
|
|
}
|
|
|
|
if accountRes.Account.AccountType != userAPI.AccountTypeGuest {
|
|
continue
|
|
}
|
|
|
|
var memberContent gomatrixserverlib.MemberContent
|
|
if err = json.Unmarshal(memberEvent.Content(), &memberContent); err != nil {
|
|
return err
|
|
}
|
|
memberContent.Membership = spec.Leave
|
|
|
|
stateKey := *memberEvent.StateKey()
|
|
fledglingEvent := &gomatrixserverlib.ProtoEvent{
|
|
RoomID: event.RoomID().String(),
|
|
Type: spec.MRoomMember,
|
|
StateKey: &stateKey,
|
|
SenderID: stateKey,
|
|
PrevEvents: prevEvents,
|
|
}
|
|
|
|
if fledglingEvent.Content, err = json.Marshal(memberContent); err != nil {
|
|
return err
|
|
}
|
|
|
|
eventsNeeded, err := gomatrixserverlib.StateNeededForProtoEvent(fledglingEvent)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
signingIdentity, err := r.SigningIdentity(ctx, event.RoomID(), *memberUserID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
event, err := eventutil.BuildEvent(ctx, fledglingEvent, &signingIdentity, time.Now(), &eventsNeeded, latestRes)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
inputEvents = append(inputEvents, api.InputRoomEvent{
|
|
Kind: api.KindNew,
|
|
Event: event,
|
|
Origin: memberUserID.Domain(),
|
|
SendAsServer: string(memberUserID.Domain()),
|
|
})
|
|
prevEvents = []string{event.EventID()}
|
|
}
|
|
|
|
inputReq := &api.InputRoomEventsRequest{
|
|
InputRoomEvents: inputEvents,
|
|
Asynchronous: true, // Needs to be async, as we otherwise create a deadlock
|
|
}
|
|
inputRes := &api.InputRoomEventsResponse{}
|
|
r.InputRoomEvents(ctx, inputReq, inputRes)
|
|
return nil
|
|
}
|