dendrite/clientapi/auth/login_publickey_ethereum_test.go
Tak Wai Wong 82d635f237 Pull latest changes from dendrite fork (#193)
* Verify that the user ID for registration matches the spec, and the auth data (#10)

* Blacklist some sytest tests that are failing in our environment

* Commenting out test that isn't reliably passing or failing, probably a race

* refresh latest dendrite main

* pull latest from dendrite-fork subtree

* refresh latest dendrite main

* pull dendrite subtree and resolve merge conflicts

* check that userID matches the signed message

* verify that the user ID for registration is CAIP-10 compliant and MXID compliant

* removed space

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Fix nats.go commit (#2540)

Signed-off-by: Jean Lucas <jean@4ray.co>

* Don't return `end` if there are not more messages (#2542)

* Be more spec compliant

* Move lazyLoadMembers to own method

* Return an error if trying to invite a malformed user ID (#2543)

* Add `evacuateUser` endpoint, use it when deactivating accounts (#2545)

* Add `evacuateUser` endpoint, use it when deactivating accounts

* Populate the API

* Clean up user devices when deactivating

* Include invites, delete pushers

* Silence presence logs (#2547)

* Blacklist `Guest users can join guest_access rooms` test until it can be investigated

* Disable WebAssembly builds for now

* Try to fix backfilling (#2548)

* Try to fix backfilling

* Return start/end to not confuse clients

* Update GMSL

* Update GMSL

* Roomserver producers package (#2546)

* Give the roomserver a producers package

* Change init point

* Populate ACLs API

* Fix build issues

* `RoomEventProducer` naming

* Version 0.8.9 (#2549)

* Version 0.8.9

* Update changelog

* Takwaiw/fix concurrent registration bug (#12)

* fix concurrent registration bug. Rename decentralizedid

* remove unused module

* add regressed test to blacklist

Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Test_UserStatistics Fix expected results to match observed results

* Takwaiw/dendrite publickey (#2)

* Implementation of MSC 3782 Add publickey login as a new auth type.

Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Implement EIP-4361 sign in with Ethereum (#5)

* Blacklist some sytest tests that are failing in our environment

* Commenting out test that isn't reliably passing or failing, probably a race

* refresh latest dendrite main

* refresh latest dendrite main

* dendrite implementation of eip-4361

* simplify nonce generation

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Use rand.Seed to seed the random function generator (#6)

* Blacklist some sytest tests that are failing in our environment

* Commenting out test that isn't reliably passing or failing, probably a race

* refresh latest dendrite main

* use rand.Seed to seed the random function

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Create session ID during registration (#8)

* Blacklist some sytest tests that are failing in our environment

* Commenting out test that isn't reliably passing or failing, probably a race

* refresh latest dendrite main

* pull latest from dendrite-fork subtree

* refresh latest dendrite main

* Create session ID during registration

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Verify that the user ID for registration matches the spec, and the auth data (#10)

* Blacklist some sytest tests that are failing in our environment

* Commenting out test that isn't reliably passing or failing, probably a race

* refresh latest dendrite main

* pull latest from dendrite-fork subtree

* refresh latest dendrite main

* pull dendrite subtree and resolve merge conflicts

* check that userID matches the signed message

* verify that the user ID for registration is CAIP-10 compliant and MXID compliant

* removed space

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* Takwaiw/fix concurrent registration bug (#12)

* fix concurrent registration bug. Rename decentralizedid

* remove unused module

* add regressed test to blacklist

Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>

* removed unused module

* feat+fix: Ignore unknown keys and verify required fields are present in appservice registration files (#2550)

* fix: ignore unknown keys in appservice configs

fixes matrix-org/dendrite#1567

* feat: verify required fields in appservice configs

* Use new testrig for key changes tests (#2552)

* Use new testrig for tests

* Log the error message

* Fix QuerySharedUsers for the SyncAPI keychange consumer (#2554)

* Make more use of base.BaseDendrite

* Fix QuerySharedUsers if no UserIDs are supplied

* Return clearer error when no state NID exists for an event (#2555)

* Wrap error from `SnapshotNIDFromEventID`

* Hopefully fix read receipts timestamps (#2557)

This should avoid coercions between signed and unsigned ints which might fix problems like `sql: converting argument $5 type: uint64 values with high bit set are not supported`.

* fix concurrency issue when checking session ID (#14)

Co-authored-by: Tak Wai Wong <tak@hntlabs.com>

* merge latest changes from dendrite main (#15)

Co-authored-by: Tak Wai Wong <tak@hntlabs.com>

* Login and Register tests for public key ethereum (#16)

* TestLoginPublicKeyNewSession

* use asserts

* setup, test, asserts

* TestLoginPublicKeyValidAuthTypeMissingSession

* invalid session id test

* create a helper newSession function

* TestLoginPublicKeyEthereumMissingUserId

* TestLoginPublicKeyEthereumAccountNotAvailable

* TestLoginPublicKeyEthereumInvalidUserId

* createEip4361TestMessage

* TestLoginPublicKeyEthereumMissingSignature

* TestLoginPublicKeyEthereum

* re-enable all publickey signin tests

* move common publickey test util to its own file

* register_public_key.go stub

* refactored common ethereum test helpers to its own folder

* refactor test helpers

* return error in test helpers

* fix regressions with ServerName

* TestRegistrationUnimplementedAlgo

* TestNewRegistration

* TestNewRegistrationSession

* verify new login session

* remove assert

* perform account creation

* TestRegisterEthereum

* Enable all tests

* move helper functions into test file

Co-authored-by: Tak Wai Wong <tak@hntlabs.com>

Co-authored-by: Brian Meek <brian@hntlabs.com>
Co-authored-by: Tak Wai Wong <takwaiw@gmail.com>
Co-authored-by: Jean Lucas <jean@4ray.co>
Co-authored-by: Till <2353100+S7evinK@users.noreply.github.com>
Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
Co-authored-by: Tak Wai Wong <tak@hntlabs.com>
Co-authored-by: Kabir Kwatra <kabir@kwatra.me>
2022-07-14 15:24:37 -07:00

473 lines
11 KiB
Go

// Copyright 2022 The Matrix.org Foundation C.I.C.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package auth
import (
"context"
"fmt"
"net/http"
"strings"
"testing"
"github.com/matrix-org/dendrite/clientapi/jsonerror"
"github.com/matrix-org/dendrite/internal/mapsutil"
"github.com/matrix-org/dendrite/setup/config"
"github.com/matrix-org/dendrite/test"
uapi "github.com/matrix-org/dendrite/userapi/api"
"github.com/stretchr/testify/assert"
)
type loginContext struct {
config *config.ClientAPI
userInteractive *UserInteractive
}
func createLoginContext(t *testing.T) *loginContext {
chainIds := []int{4}
cfg := &config.ClientAPI{
Matrix: &config.Global{
ServerName: test.TestServerName,
},
Derived: &config.Derived{},
PasswordAuthenticationDisabled: true,
PublicKeyAuthentication: config.PublicKeyAuthentication{
Ethereum: config.EthereumAuthConfig{
Enabled: true,
Version: 1,
ChainIDs: chainIds,
},
},
}
pkFlows := cfg.PublicKeyAuthentication.GetPublicKeyRegistrationFlows()
cfg.Derived.Registration.Flows = append(cfg.Derived.Registration.Flows, pkFlows...)
pkParams := cfg.PublicKeyAuthentication.GetPublicKeyRegistrationParams()
cfg.Derived.Registration.Params = mapsutil.MapsUnion(cfg.Derived.Registration.Params, pkParams)
var userAPI fakePublicKeyUserApi
var loginApi uapi.UserLoginAPI
userInteractive := NewUserInteractive(
loginApi,
&userAPI,
cfg)
return &loginContext{
config: cfg,
userInteractive: userInteractive,
}
}
type fakePublicKeyUserApi struct {
UserInternalAPIForLogin
uapi.UserLoginAPI
uapi.ClientUserAPI
DeletedTokens []string
}
func (ua *fakePublicKeyUserApi) QueryAccountAvailability(ctx context.Context, req *uapi.QueryAccountAvailabilityRequest, res *uapi.QueryAccountAvailabilityResponse) error {
if req.Localpart == "does_not_exist" {
res.Available = true
return nil
}
res.Available = false
return nil
}
func (ua *fakePublicKeyUserApi) QueryAccountByPassword(ctx context.Context, req *uapi.QueryAccountByPasswordRequest, res *uapi.QueryAccountByPasswordResponse) error {
if req.PlaintextPassword == "invalidpassword" {
res.Account = nil
return nil
}
res.Exists = true
res.Account = &uapi.Account{}
return nil
}
func (ua *fakePublicKeyUserApi) PerformLoginTokenDeletion(ctx context.Context, req *uapi.PerformLoginTokenDeletionRequest, res *uapi.PerformLoginTokenDeletionResponse) error {
ua.DeletedTokens = append(ua.DeletedTokens, req.Token)
return nil
}
func (ua *fakePublicKeyUserApi) PerformLoginTokenCreation(ctx context.Context, req *uapi.PerformLoginTokenCreationRequest, res *uapi.PerformLoginTokenCreationResponse) error {
return nil
}
func (*fakePublicKeyUserApi) QueryLoginToken(ctx context.Context, req *uapi.QueryLoginTokenRequest, res *uapi.QueryLoginTokenResponse) error {
if req.Token == "invalidtoken" {
return nil
}
res.Data = &uapi.LoginTokenData{UserID: "@auser:example.com"}
return nil
}
func publicKeyTestSession(
ctx *context.Context,
cfg *config.ClientAPI,
userInteractive *UserInteractive,
userAPI *fakePublicKeyUserApi,
) string {
emptyAuth := struct {
Body string
}{
Body: `{
"type": "m.login.publickey"
}`,
}
_, cleanup, err := LoginFromJSONReader(
*ctx,
strings.NewReader(emptyAuth.Body),
userAPI,
userAPI,
userAPI,
userInteractive,
cfg)
if cleanup != nil {
cleanup(*ctx, nil)
}
json := err.JSON.(Challenge)
return json.Session
}
func TestLoginPublicKeyEthereum(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
wallet, _ := test.CreateTestAccount()
message, _ := test.CreateEip4361TestMessage(wallet.PublicAddress)
signature, _ := test.SignMessage(message.String(), wallet.PrivateKey)
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
// Escape \t and \n. Work around for marshalling and unmarshalling message.
msgStr := test.FromEip4361MessageToString(message)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v",
"user_id": "%v",
"message": "%v",
"signature": "%v"
}
}`,
sessionId,
wallet.Eip155UserId,
msgStr,
signature,
)
test := struct {
Body string
}{
Body: body,
}
// Test
login, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Nilf(err, "err actual: %v, expected: nil", err)
assert.NotNil(login, "login: actual: nil, expected: not nil")
assert.Truef(
login.Identifier.Type == "m.id.decentralizedid",
"login.Identifier.Type actual: %v, expected: %v", login.Identifier.Type, "m.id.decentralizedid")
walletAddress := strings.ToLower(wallet.Eip155UserId)
assert.Truef(
login.Identifier.User == walletAddress,
"login.Identifier.User actual: %v, expected: %v", login.Identifier.User, walletAddress)
}
func TestLoginPublicKeyEthereumMissingSignature(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
wallet, _ := test.CreateTestAccount()
message, _ := test.CreateEip4361TestMessage(wallet.PublicAddress)
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
// Escape \t and \n. Work around for marshalling and unmarshalling message.
msgStr := test.FromEip4361MessageToString(message)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v",
"user_id": "%v",
"message": "%v"
}
}`,
sessionId,
wallet.Eip155UserId,
msgStr,
)
test := struct {
Body string
}{
Body: body,
}
// Test
_, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Truef(
err.Code == http.StatusUnauthorized,
"err.Code actual: %v, expected: %v", err.Code, http.StatusUnauthorized)
json := err.JSON.(*jsonerror.MatrixError)
expectedErr := jsonerror.InvalidSignature("")
assert.Truef(
json.ErrCode == expectedErr.ErrCode,
"err.JSON.ErrCode actual: %v, expected: %v", json.ErrCode, expectedErr.ErrCode)
}
func TestLoginPublicKeyEthereumEmptyMessage(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
wallet, _ := test.CreateTestAccount()
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v",
"user_id": "%v"
}
}`, sessionId, wallet.Eip155UserId)
test := struct {
Body string
}{
Body: body,
}
// Test
_, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Truef(
err.Code == http.StatusUnauthorized,
"err.Code actual: %v, expected: %v", err.Code, http.StatusUnauthorized)
json := err.JSON.(*jsonerror.MatrixError)
expectedErr := jsonerror.InvalidParam("")
assert.Truef(
json.ErrCode == expectedErr.ErrCode,
"err.JSON.ErrCode actual: %v, expected: %v", json.ErrCode, expectedErr.ErrCode)
}
func TestLoginPublicKeyEthereumWrongUserId(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
wallet, _ := test.CreateTestAccount()
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v",
"user_id": "%v"
}
}`,
sessionId,
wallet.PublicAddress)
test := struct {
Body string
}{
Body: body,
}
// Test
_, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Truef(
err.Code == http.StatusForbidden,
"err.Code actual: %v, expected: %v", err.Code, http.StatusForbidden)
}
func TestLoginPublicKeyEthereumMissingUserId(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v"
}
}`, sessionId)
test := struct {
Body string
}{
Body: body,
}
// Test
_, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Truef(
err.Code == http.StatusForbidden,
"err.Code actual: %v, expected: %v", err.Code, http.StatusForbidden)
}
func TestLoginPublicKeyEthereumAccountNotAvailable(t *testing.T) {
// Setup
var userAPI fakePublicKeyUserApi
ctx := context.Background()
loginContext := createLoginContext(t)
sessionId := publicKeyTestSession(
&ctx,
loginContext.config,
loginContext.userInteractive,
&userAPI,
)
body := fmt.Sprintf(`{
"type": "m.login.publickey",
"auth": {
"type": "m.login.publickey.ethereum",
"session": "%v",
"user_id": "does_not_exist"
}
}`, sessionId)
test := struct {
Body string
}{
Body: body,
}
// Test
_, cleanup, err := LoginFromJSONReader(
ctx,
strings.NewReader(test.Body),
&userAPI,
&userAPI,
&userAPI,
loginContext.userInteractive,
loginContext.config)
if cleanup != nil {
cleanup(ctx, nil)
}
// Asserts
assert := assert.New(t)
assert.Truef(
err.Code == http.StatusForbidden,
"err.Code actual: %v, expected: %v", err.Code, http.StatusForbidden)
}