sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

remove unnecessary txn for SelectPeeks

Browse source
This commit is contained in:
Matthew Hodgson 2020-09-01 00:24:23 +03:00
parent e5899843ea
commit 0bb2c2c418
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
syncapi/storage/shared/syncserver.go
View file

@ -695,7 +695,7 @@ func (d *Database) getResponseWithPDUsForCompleteSync(
} }
// Add peeked rooms. // Add peeked rooms.
peeks, err := d.Peeks.SelectPeeks(ctx, txn, userID, deviceID) peeks, err := d.Peeks.SelectPeeks(ctx, userID, deviceID)
if err != nil { if err != nil {
return return
} }
@ -1026,7 +1026,7 @@ func (d *Database) getStateDeltas(
// find out which rooms this user is peeking, if any. // find out which rooms this user is peeking, if any.
// We do this before joins so joins overwrite peeks // We do this before joins so joins overwrite peeks
peeks, err := d.Peeks.SelectPeeks(ctx, txn, userID, device.ID) peeks, err := d.Peeks.SelectPeeks(ctx, userID, device.ID)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }
@ -1128,7 +1128,7 @@ func (d *Database) getStateDeltasForFullStateSync(
return nil, nil, err return nil, nil, err
} }
peeks, err := d.Peeks.SelectPeeks(ctx, txn, userID, device.ID) peeks, err := d.Peeks.SelectPeeks(ctx, userID, device.ID)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }

4
syncapi/storage/sqlite3/peeks_table.go
View file

@ -136,9 +136,9 @@ func (s *peekStatements) DeletePeeks(
} }
func (s *peekStatements) SelectPeeks( func (s *peekStatements) SelectPeeks(
ctx context.Context, txn *sql.Tx, userID, deviceID string, ctx context.Context, userID, deviceID string,
) (peeks []types.Peek, err error) { ) (peeks []types.Peek, err error) {
rows, err := sqlutil.TxStmt(txn, s.selectPeeksStmt).QueryContext(ctx, userID, deviceID) rows, err := s.selectPeeksStmt.QueryContext(ctx, userID, deviceID)
if err != nil { if err != nil {
return return
} }

2
syncapi/storage/tables/interface.go
View file

@ -43,7 +43,7 @@ type Peeks interface {
InsertPeek(ctx context.Context, txn *sql.Tx, roomID, userID, deviceID string) (streamPos types.StreamPosition, err error) InsertPeek(ctx context.Context, txn *sql.Tx, roomID, userID, deviceID string) (streamPos types.StreamPosition, err error)
DeletePeek(ctx context.Context, txn *sql.Tx, roomID, userID, deviceID string) (streamPos types.StreamPosition, err error) DeletePeek(ctx context.Context, txn *sql.Tx, roomID, userID, deviceID string) (streamPos types.StreamPosition, err error)
DeletePeeks(ctx context.Context, txn *sql.Tx, roomID, userID string) (streamPos types.StreamPosition, err error) DeletePeeks(ctx context.Context, txn *sql.Tx, roomID, userID string) (streamPos types.StreamPosition, err error)
SelectPeeks(ctxt context.Context, txn *sql.Tx, userID, deviceID string) (peeks []types.Peek, err error) SelectPeeks(ctxt context.Context, userID, deviceID string) (peeks []types.Peek, err error)
SelectPeekingDevices(ctxt context.Context) (peekingDevices map[string][]types.PeekingDevice, err error) SelectPeekingDevices(ctxt context.Context) (peekingDevices map[string][]types.PeekingDevice, err error)
MarkPeeksAsOld(ctxt context.Context, txn *sql.Tx, userID, deviceID string) (err error) MarkPeeksAsOld(ctxt context.Context, txn *sql.Tx, userID, deviceID string) (err error)
} }