sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

Fix error handling in federationsender

Browse source
This commit is contained in:
Neil Alexander 2020-07-07 16:53:10 +01:00
parent 8e9580852d
commit 51fd532940
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
federationsender/queue/destinationqueue.go
View file

@ -397,15 +397,8 @@ func (oq *destinationQueue) nextTransaction(
} }
return true, nil return true, nil
case gomatrix.HTTPError: case gomatrix.HTTPError:
// We received a HTTP error back. In this instance we only // Report that we failed to send the transaction and we
// should report an error if // will retry again, subject to backoff.
if e.Code >= 400 && e.Code <= 499 {
// We tried but the remote side has sent back a client error.
// It's no use retrying because it will happen again.
return true, nil
}
// Otherwise, report that we failed to send the transaction
// and we will retry again.
return false, err return false, err
default: default:
log.WithFields(log.Fields{ log.WithFields(log.Fields{