sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

Placeholder comments for modifications needed to /send_join for power DAG

Browse source
This commit is contained in:
Devon Hudson 2023-04-19 18:25:43 -06:00
parent a3b87f477c
commit 549d20cb61
No known key found for this signature in database
GPG key ID: CD06B18E77F6A628
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
federationapi/routing/join.go
View file

@ -312,6 +312,9 @@ func SendJoin(
} }
} }
// TODO: (PowerDAG) query state & power DAG
// We return the entire power DAG with a send_join response
// Fetch the state and auth chain. We do this before we send the events // Fetch the state and auth chain. We do this before we send the events
// on, in case this fails. // on, in case this fails.
var stateAndAuthChainResponse api.QueryStateAndAuthChainResponse var stateAndAuthChainResponse api.QueryStateAndAuthChainResponse
@ -339,6 +342,9 @@ func SendJoin(
} }
} }
// TODO: (Power DAG) will we have enough info in a join response to check membership?
// We should include the user membership event (if there is one) in the state response.
// Check if the user is already in the room. If they're already in then // Check if the user is already in the room. If they're already in then
// there isn't much point in sending another join event into the room. // there isn't much point in sending another join event into the room.
// Also check to see if they are banned: if they are then we reject them. // Also check to see if they are banned: if they are then we reject them.
@ -425,6 +431,8 @@ func SendJoin(
} }
} }
// TODO: (PowerDAG) Adapt this to return the full power DAG & state + user membership event (if it exists)
// sort events deterministically by depth (lower is earlier) // sort events deterministically by depth (lower is earlier)
// We also do this because sytest's basic federation server isn't good at using the correct // We also do this because sytest's basic federation server isn't good at using the correct
// state if these lists are randomised, resulting in flakey tests. :( // state if these lists are randomised, resulting in flakey tests. :(