sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

mediaapi/writers/download: Clarify validation applied to Origin

Browse source
This commit is contained in:
Robert Swain 2017-05-26 14:59:45 +02:00
parent 4dfbae81cd
commit 98ef88b668
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/github.com/matrix-org/dendrite/mediaapi/writers/download.go
View file

@ -91,6 +91,8 @@ func (r *downloadRequest) Validate() *util.JSONResponse {
JSON: jsonerror.NotFound(fmt.Sprintf("mediaId must be a non-empty string using only characters in %v", mediaIDCharacters)), JSON: jsonerror.NotFound(fmt.Sprintf("mediaId must be a non-empty string using only characters in %v", mediaIDCharacters)),
} }
} }
// Note: the origin will be validated either by comparison to the configured server name of this homeserver
// or by a DNS SRV record lookup when creating a request for remote files
if r.MediaMetadata.Origin == "" { if r.MediaMetadata.Origin == "" {
return &util.JSONResponse{ return &util.JSONResponse{
Code: 404, Code: 404,