sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

De-race TestExpireEDUs (#2654)

Browse source 
In some conditions (fast CPUs), this test would race the clock for EDU expiration when all we want to make sure of is that the expired EDUs are properly deleted. Given this, we set the expiry time to 0 so the specified EDUs are always deleted when DeleteExpiredEDUs is called.
Fixes #2650.

Signed-off-by: Winter <winter@winter.cafe>
This commit is contained in:
Winter 2022-08-19 01:28:33 -04:00 committed by GitHub
parent 6b48ce0d75
commit a379d3e814
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
federationapi/storage/storage_test.go
View file

@ -31,7 +31,7 @@ func mustCreateFederationDatabase(t *testing.T, dbType test.DBType) (storage.Dat
func TestExpireEDUs(t *testing.T) { func TestExpireEDUs(t *testing.T) {
var expireEDUTypes = map[string]time.Duration{ var expireEDUTypes = map[string]time.Duration{
gomatrixserverlib.MReceipt: time.Millisecond, gomatrixserverlib.MReceipt: 0,
} }
ctx := context.Background() ctx := context.Background()