sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

Skip tests that require a database if we can't connect to one (#2413)

Browse source 
* Skip tests that require a database if we can't connect to one

* Add `DENDRITE_SKIP_DB_TESTS` environment variable to bring @kegsay joy

* Call it `DENDRITE_TEST_SKIP_NODB` intead
This commit is contained in:
Neil Alexander 2022-05-03 17:38:54 +01:00 committed by GitHub
parent dd061a172e
commit e01d1e1f5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
test/db.go
View file

@ -33,10 +33,19 @@ var DBTypeSQLite DBType = 1
var DBTypePostgres DBType = 2 var DBTypePostgres DBType = 2
var Quiet = false var Quiet = false
var Required = os.Getenv("DENDRITE_TEST_SKIP_NODB") == ""
func createLocalDB(dbName string) { func fatalError(t *testing.T, format string, args ...interface{}) {
if Required {
t.Fatalf(format, args...)
} else {
t.Skipf(format, args...)
}
}
func createLocalDB(t *testing.T, dbName string) {
if !Quiet { if !Quiet {
fmt.Println("Note: tests require a postgres install accessible to the current user") t.Log("Note: tests require a postgres install accessible to the current user")
} }
createDB := exec.Command("createdb", dbName) createDB := exec.Command("createdb", dbName)
if !Quiet { if !Quiet {
@ -44,15 +53,15 @@ func createLocalDB(dbName string) {
createDB.Stderr = os.Stderr createDB.Stderr = os.Stderr
} }
err := createDB.Run() err := createDB.Run()
if err != nil && !Quiet { if err != nil {
fmt.Println("createLocalDB returned error:", err) fatalError(t, "createLocalDB returned error: %s", err)
} }
} }
func createRemoteDB(t *testing.T, dbName, user, connStr string) { func createRemoteDB(t *testing.T, dbName, user, connStr string) {
db, err := sql.Open("postgres", connStr+" dbname=postgres") db, err := sql.Open("postgres", connStr+" dbname=postgres")
if err != nil { if err != nil {
t.Fatalf("failed to open postgres conn with connstr=%s : %s", connStr, err) fatalError(t, "failed to open postgres conn with connstr=%s : %s", connStr, err)
} }
_, err = db.Exec(fmt.Sprintf(`CREATE DATABASE %s;`, dbName)) _, err = db.Exec(fmt.Sprintf(`CREATE DATABASE %s;`, dbName))
if err != nil { if err != nil {
@ -133,7 +142,7 @@ func PrepareDBConnectionString(t *testing.T, dbType DBType) (connStr string, clo
hash := sha256.Sum256([]byte(wd)) hash := sha256.Sum256([]byte(wd))
dbName := fmt.Sprintf("dendrite_test_%s", hex.EncodeToString(hash[:16])) dbName := fmt.Sprintf("dendrite_test_%s", hex.EncodeToString(hash[:16]))
if postgresDB == "" { // local server, use createdb if postgresDB == "" { // local server, use createdb
createLocalDB(dbName) createLocalDB(t, dbName)
} else { // remote server, shell into the postgres user and CREATE DATABASE } else { // remote server, shell into the postgres user and CREATE DATABASE
createRemoteDB(t, dbName, user, connStr) createRemoteDB(t, dbName, user, connStr)
} }