sigb.us/dendrite
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases 1 Wiki Activity

Fix a bug where we would accidentally skip over some events

Browse source
This commit is contained in:
Till Faelligen 2024-05-15 11:02:23 +02:00
parent a7953fe3ff
commit fb5e1abe71
No known key found for this signature in database
GPG key ID: ACCDC9606D472758
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
syncapi/sync/requestpool.go
View file

@ -400,6 +400,9 @@ func (rp *RequestPool) OnIncomingSyncRequest(req *http.Request, device *userapi.
reasonablePositions := findReasonableIncrementalSyncWindow( reasonablePositions := findReasonableIncrementalSyncWindow(
syncReq.Since, rp.Notifier.CurrentPosition(), syncReq.Since, rp.Notifier.CurrentPosition(),
) )
// Also update the currentPos, which is used for the retry logic below.
// Otherwise we may skip over some events.
currentPos = reasonablePositions
syncReq.Response.NextBatch = types.StreamingToken{ syncReq.Response.NextBatch = types.StreamingToken{
PDUPosition: withTransaction( PDUPosition: withTransaction(
syncReq.Since.PDUPosition, syncReq.Since.PDUPosition,