Don't 500 /messages if we can't apply history visibility correctly

syncapi/routing/messages.go

@@ -362,13 +362,16 @@ func (r *messagesReq) retrieveEvents() (
 
 	// Apply room history visibility filter
 	startTime := time.Now()
-	filteredEvents, err := internal.ApplyHistoryVisibilityFilter(r.ctx, r.snapshot, r.rsAPI, events, nil, r.device.UserID, "messages")
+	filteredEvents := events
-	logrus.WithFields(logrus.Fields{
+	if filtered, ferr := internal.ApplyHistoryVisibilityFilter(r.ctx, r.snapshot, r.rsAPI, events, nil, r.device.UserID, "messages"); ferr == nil {
-		"duration":      time.Since(startTime),
+		filteredEvents = filtered
-		"room_id":       r.roomID,
+		logrus.WithFields(logrus.Fields{
-		"events_before": len(events),
+			"duration":      time.Since(startTime),
-		"events_after":  len(filteredEvents),
+			"room_id":       r.roomID,
-	}).Debug("applied history visibility (messages)")
+			"events_before": len(events),
+			"events_after":  len(filteredEvents),
+		}).Debug("applied history visibility (messages)")
+	}
 	return gomatrixserverlib.HeaderedToClientEvents(filteredEvents, gomatrixserverlib.FormatAll), start, end, err
 }