Avoid unnecessary loop

This commit is contained in:
Till Faelligen 2023-07-10 15:52:27 +02:00
parent 0ebea98beb
commit 41cf902d09
No known key found for this signature in database
GPG key ID: ACCDC9606D472758

View file

@ -567,15 +567,17 @@ func (r *messagesReq) backfill(roomID string, backwardsExtremities map[string][]
if res.HistoryVisibility == "" { if res.HistoryVisibility == "" {
res.HistoryVisibility = gomatrixserverlib.HistoryVisibilityShared res.HistoryVisibility = gomatrixserverlib.HistoryVisibilityShared
} }
for i := range res.Events { events := res.Events
for i := range events {
events[i].Visibility = res.HistoryVisibility
_, err = r.db.WriteEvent( _, err = r.db.WriteEvent(
context.Background(), context.Background(),
res.Events[i], events[i],
[]*rstypes.HeaderedEvent{}, []*rstypes.HeaderedEvent{},
[]string{}, []string{},
[]string{}, []string{},
nil, true, nil, true,
res.HistoryVisibility, events[i].Visibility,
) )
if err != nil { if err != nil {
return nil, err return nil, err
@ -583,14 +585,10 @@ func (r *messagesReq) backfill(roomID string, backwardsExtremities map[string][]
} }
// we may have got more than the requested limit so resize now // we may have got more than the requested limit so resize now
events := res.Events
if len(events) > limit { if len(events) > limit {
// last `limit` events // last `limit` events
events = events[len(events)-limit:] events = events[len(events)-limit:]
} }
for _, ev := range events {
ev.Visibility = res.HistoryVisibility
}
return events, nil return events, nil
} }