Fix MembershipUpdater method to not commit the transaction before returning it

src/github.com/matrix-org/dendrite/roomserver/storage/storage.go

@@ -17,8 +17,6 @@ package storage
 import (
 	"database/sql"
 
-	"github.com/matrix-org/dendrite/common"
-
 	// Import the postgres database driver.
 	_ "github.com/lib/pq"
 	"github.com/matrix-org/dendrite/roomserver/types"
@@ -383,24 +381,35 @@ func (d *Database) StateEntriesForTuples(
 }
 
 // MembershipUpdater implements input.RoomEventDatabase
-func (d *Database) MembershipUpdater(roomID, targetUserID string) (updater types.MembershipUpdater, err error) {
+func (d *Database) MembershipUpdater(roomID, targetUserID string) (types.MembershipUpdater, error) {
-	err = common.WithTransaction(d.db, func(txn *sql.Tx) error {
+	txn, err := d.db.Begin()
-		var (
-			roomNID       types.RoomNID
-			targetUserNID types.EventStateKeyNID
-		)
-		roomNID, err = d.assignRoomNID(txn, roomID)
 	if err != nil {
-			return err
+		return nil, err
 	}
-		targetUserNID, err = d.assignStateKeyNID(txn, targetUserID)
+	succeeded := false
+	defer func() {
+		if !succeeded {
+			txn.Rollback()
+		}
+	}()
+
+	roomNID, err := d.assignRoomNID(txn, roomID)
 	if err != nil {
-			return err
+		return nil, err
 	}
-		updater, err = d.membershipUpdaterTxn(txn, roomNID, targetUserNID)
+
-		return err
+	targetUserNID, err := d.assignStateKeyNID(txn, targetUserID)
-	})
+	if err != nil {
-	return
+		return nil, err
+	}
+
+	updater, err := d.membershipUpdaterTxn(txn, roomNID, targetUserNID)
+	if err != nil {
+		return nil, err
+	}
+
+	succeeded = true
+	return updater, nil
 }
 
 type membershipUpdater struct {